On 12/11/13, Tyler Romeo <[email protected]> wrote: > On Wed, Dec 11, 2013 at 3:19 PM, Brian Wolff <[email protected]> wrote: > >> One of the primary reasons gadgets/local-js exist is because local >> wiki-admins feel that the mediawiki code review process is unavailable >> to them. I would expect any sort of code review requirement for >> gadgets to meet strong resistance, especially on the smaller wikis. >> >> I also think it would be unenforcable unless one plans to ban personal >>
>Not necessarily. Individual user JS applies only to the one user, >while gadgets apply to potentially many and [[MediaWiki:Common.js]] to >everyone. I guess I should have said without banning [[MediaWiki:Common.js]]. I was kind of assuming this proposal meant banning all site wide js (Since otherwise what's the point of banning default on gadgets? Default on gadgets is just a way to separate common.js into modules for easier maintainability) > > In this case we should promptly work to fix this issue. To be honest, the > only difficult part of our code review process is having to learn Git if > you do not already know how to use it. If there were a way to submit > patchsets without using Git somehow (maybe some kind of desktop > application), it may make things easier. Submitting patches is not the problem. Getting them reviewed in a timely fashion is a problem. Having power taken out of local wikis hands is a problem. --bawolff _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
