On 9 April 2014 09:12, Jon Robson <[email protected]> wrote: > From a personal perspective, the fact we have so much code to review > in the Gerrit code review queue makes it harder for __me__ to > prioritise the important patchsets and thus review them.
For which repos? Do those repos have a proper dashboard set up, or are they just using the default one? For example, in VisualEditor, the default "Recent Changes" dashboard is pretty useless: https://gerrit.wikimedia.org/r/#/projects/mediawiki/extensions/VisualEditor,dashboards/default:recent … whereas the custom multi-part one we have is much more useful at prioritising, especially cross-repo issues: https://gerrit.wikimedia.org/r/#/projects/mediawiki/extensions/VisualEditor,dashboards/custom:custom I can imagine that for e.g. the Mobile and Multimedia teams, who have a bunch of different repos in which they work, that this might be particularly helpful. I'd be happy to help teams and interested groups build ones for other repos; mediawiki/core.git might be a bit of a challenge, but worth attempting. On the wider point, I think it would be a mistake to automatically abandon -1'ed or -2'ed patches; as Chad says, it's a pretty negative way to interact with volunteers, and as Mark says, old patches are useful to keep around as a way of reminding yourself (and team members) of non-urgent but important work (like adding a new CI test and passing it, a gargantuan task at times). J. -- James D. Forrester Product Manager, VisualEditor Wikimedia Foundation, Inc. [email protected] | @jdforrester _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
