On 8/22/14, Tyler Romeo <[email protected]> wrote: > My opinion on this matter is that if you were using a variable prefixed with > “m”, which is clearly one of our conventions for declaring variables > private, you are asking for trouble. Just recently when the password hashing > API patch was merged, it caused problems with CentralAuth since it tried > accessing mPassword directly. > > In cases like this, I don’t think there’s any need for a deprecation period, > because you are playing with fire in the first place. > > Obviously, for other variables that don’t start with “m” and are not > documented as @private or @protected, then we need the grace period. > -- > Tyler Romeo > 0x405D34A7C86B42DF
$mFoo was a historic coding convention for all member variables (including public variables). There are many explicitly public variables starting with $m: bawolff@Bawolff-L:/var/www/w/git/includes$ git grep 'public $m' |wc -l 266 I don't think we should treat $m variables any different from other variables. --bawolff _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
