On 11/24/14 7:13 PM, Mark A. Hershberger wrote: > == Changes since 1.24.0-rc.2 == > * The composer.json file has been renamed to composer.json.sample after > Jamie Thingelstad reported that his composer.json was overwritten by > the tarball.
Is there an associated bug report? We decided to revert a similar move in core and this goes against the consensus in code review and the wikitech discussions that were held months ago (back in May!), so I strongly recommend reverting this. First off, this "change"[1] was done outside of git meaning there was no opportunity for code review and no possibility of a revert. Adding a composer.json to MediaWiki has been intentionally done (see Ori's extremely long rationale on [2]) so MediaWiki can properly depend on external libraries like phpunit, and a bunch more starting with the 1.25 development cycle. This has been previously discussed on this list (see [3] and [4]) explaining why we chose to have a composer.json in core. Maybe we need better release notes documenting this switch since 1.23. I'm frustrated at why this is coming in at the last minute and done in a seemingly secret manner especially after there have been so many discussions about this that the "release team" themselves were involved in. -- Legoktm [1] https://gerrit.wikimedia.org/r/#/c/175453/ [2] https://gerrit.wikimedia.org/r/#/c/132788/ [3] https://www.mail-archive.com/[email protected]/msg76217.html [4] https://www.mail-archive.com/[email protected]/msg76250.html _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
