Seeing no reply here, I've now submitted https://gerrit.wikimedia.org/r/178527 to revert the API change and to update the UI message.
On Mon, Dec 1, 2014 at 8:30 PM, Chris Steipp <[email protected]> wrote: > Hi list, > > I wanted to get some feedback about > https://phabricator.wikimedia.org/T74222. > In the last security release, I changed the return of the api to remove the > "action" for log entries that had been revdeleted with "Hide action and > target". However, ever since 2009 / r46917, we've assumed that "Hide action > and target" didn't mean the actual action field in the db, but rather the > target and the text of the message about the action, which might include > other parameters. So the message about what's being hidden and the intended > protection of that option could have slightly different interpretations. > > I'd like to hear if anyone has intended for the actual log action to be > deleted / suppressed. If not, I'm happy to revert the recent patch, and > we'll just update the wording in the deletion UI to be more clear about > what is being removed. > _______________________________________________ > Wikitech-l mailing list > [email protected] > https://lists.wikimedia.org/mailman/listinfo/wikitech-l -- Brad Jorsch (Anomie) Software Engineer Wikimedia Foundation _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
