As stated on the bug I'd like us to get to a point where we don't have to think about this. Ideally a JavaScript dev should be able to create an oojs ui image element that is compatible with this. A server side function should also exist for creating this. On 6 May 2015 6:57 am, "Prateek Saxena" <[email protected]> wrote:
> On Tue, May 5, 2015 at 3:20 AM, Brion Vibber <[email protected]> > wrote: > > Do folks have any preference for whether I should add that as a separate > > function like $.bracketedDevicePixelRatio() or just directly bracket the > > output of the $.devicePixelRatio wrapper function? > > $.bracketedDevicePixelRatio() as a separate function, please :) > > Even though most uses of $.devicePixelRatio() are to get thumbnail > sizes (as you noted), I don't think we should change the existing > functionality. Adding a separate method seems easy enough [1] and > won't break cases where its being used for UI calculations. > > —prtksxna > > [1] as I can see in https://gerrit.wikimedia.org/r/#/c/208820/ > > _______________________________________________ > Wikitech-l mailing list > [email protected] > https://lists.wikimedia.org/mailman/listinfo/wikitech-l _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
