On Thu, May 21, 2015 at 4:43 AM, Quim Gil <[email protected]> wrote:
> > I can't review my own revisions. > > Neither should you, that is the point of code review. Then again, if there > is no workaround for this, it might be a blocker for urgent Ops deployments > (where we see many self-merged patches) and one-person projects. If this is > the case, please create a blocker for T597 so we can discuss it in detail. > We also allow for self-merging of documentation fixes that don't change any code (e.g. "Oops, I forgot the RELEASE-NOTES entry!"). And if I manually rebase someone else's patch, or amend it to clean up whitespace, or cherry-pick it to another branch (automatically? manually because of a merge conflict?), would it let me merge or count that as "my own" now? I've also had opportunity for self-merge when someone else +2s, but Jenkins decides to be stupid and either not run or have a bogus failure that needs another +2 to tell it to try again. For that matter, I've had opportunity for using "Submit and merge" when Jenkins is being broken or excessively slow during a SWAT deployment. -- Brad Jorsch (Anomie) Software Engineer Wikimedia Foundation _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
