On Thu, Jun 18, 2015 at 9:32 AM, Jon Robson <[email protected]> wrote:
> Smaller commits generally are better
I'm going to call red herring here. Whether or not smaller commits are
really better, one patch that does
+ if ( detectOldInput( $input ) ) {
+ $input = upgradeInput( $input );
+ // wfDeprecated( "You used the old input style!" );
+ }
then a followup that does
- // wfDeprecated( "You used the old input style!" );
+ wfDeprecated( "You used the old input style!" );
to be merged 1 second later[1] isn't an example.
[1]: Assuming Jenkins gets a whole lot faster about merging stuff ;)
--
Brad Jorsch (Anomie)
Software Engineer
Wikimedia Foundation
_______________________________________________
Wikitech-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
