Krinkle wrote: >TL:DR; Double-check your wiki's site scripts and your personal scripts >to ensure "document.write" is no longer used.
Thanks for the detailed e-mail. >Search results from mwgrep on all public wikis: >https://phabricator.wikimedia.org/P1832 These results seem to be limited to the "MediaWiki" namespace. I did a few 'insource:"document.write"' searches filtered to the User namespace via Special:Search and the results were surprisingly low. Suspiciously low, perhaps. Maybe somebody has already run a bot or script to clean up? Do we know approximately how many users/user scripts are affected by this change across Wikimedia wikis? Bartosz Dziewoński wrote: >I think this announcement is missing one important tidbit: > >If you have `document.write(…)` anywhere in your user JavaScript, **you >will get a blank page** on all pages of your wiki *, including the user >JavaScript page you'd have to edit to fix it, until you disable >JavaScript in your browser or ask an administrator to fix it for you. Hmmm, I wonder if throwing a blank page counts as failing softly or failing loudly. :-) Depending on the number of users impacted by this change, <https://phabricator.wikimedia.org/T108139> may not really be "Unbreak Now!"-level of priority. Ideally we'd fix/update most greppable instances of "document.write()" before deploying this type of breaking change; there's no rush, after all. MZMcBride _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
