On 2015-10-26, Brad Jorsch (Anomie) <[email protected]> wrote: Brad - thank you very much for having a look at this.
> On Sat, Oct 24, 2015 at 7:14 PM, Marcin Cieslak <[email protected]> wrote: > >> I am getting few interesting failures: >> >> - floating point format problems >> > > Why do you have serialize_precision set to 100? Once you go over the > default of 17, you're into the range of rounding errors in an IEEE double, > which in turn is what PHP typically is using for its float type. > > This probably doesn't break anything besides unit tests, though. That is probably inherited from the vendor's (Gentoo) defaults. This should probably fixed in the test - to have a fixed precision in the test, enforced by ini_set() in the worst case. Is there any requirement for those serializations to be consistent in the API? If yes, then probably the API value formatting should be more tightly formatted. The test passes after setting serialize_precision to 14. >> - various XMP XML metadata issues >> > > This seems to cover most of your errors. In particular, the metadata seems > to be completely missing. What might be happening there is that > XMPReader::isSupported() may be returning false on your system due to > missing dependencies, and all these tests should be made to skip in that > case. A quick test with eval.php gives me > var_dump(XMPReader::isSupported()) bool(true) Will investigate. >> and few others. >> > > The only "other" looks like failures 3-6, which seems to boil down to some > issue with JavaScriptContent::getRedirectTarget() recognizing redirects in > general. If you can manage to figure out one of them (e.g. failure 4), it > will probably figure out all of them. My guess offhand is that something in > your setup is making the preg_match() in that function fail to match. I think that 'wgScriptPath' set to '/w/index.php' might be incorrect (I think they meant 'wgScript'). I have $wgScriptPath = "/~saper/ybabel"; in my LocalSettings.php and this confuses the test. https://gerrit.wikimedia.org/r/249004 fixes this for me. Marcin _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
