On 10 December 2015 at 18:48, James Forrester <[email protected]> wrote:
> On 10 December 2015 at 17:12, Jon Robson <[email protected]> wrote: > >> So I enabled a beta feature today that is part of reading web's >> quarterly goals (read more about read more here if interested [1]) >> >> When enabled it showed up in desktop beta features (yey) but the >> JavaScript module wasn't loading... >> >> Investigating I discovered that BetaFeatures::isEnabled consults a >> config variable called wgBetaFeaturesWhitelist >> >> This makes the feature return false if the feature is not in >> wgBetaFeaturesWhitelist >> >> Apparently however you make the feature show up in the >> GetBetaFeaturePreferences hook - so the whitelist doesn't actually >> apply to things we show to users (which I would say would be more >> important...) [2] >> > > Hmm. That's an odd bug. I'm pretty sure it didn't used to work if it > wasn't in the whitelist at all, not merely partially. Thanks for the bug > report, and I see you've filed it as > https://phabricator.wikimedia.org/T121182. Thank you; I'll see if we can > get it fixed PDQ. > Update: This was a logic bug by me, now fixed in master thanks to Sumit. It'll roll out in the train next week; given there's no current live-but-not-whitelisted BF code in production, so I think there's no need to rush it out early. J. -- James D. Forrester Lead Product Manager, Editing Wikimedia Foundation, Inc. [email protected] | @jdforrester _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
