We have two swat windows every day. It's magical... I post a request for a deploy on a Wiki page and someone deploys it.
Could we try a similar thing with code review. Code review window (maximum 1 patch per person) and have a group of +2ers look at a maximum set of patches? It would need a few more rules than that and a bit of tweaking but seems like a good experiment. I'd sign up to help it if it was a maximum 2 windows for me a week. On 16 Mar 2016 12:50 p.m., "Daniel Kinzler" <[email protected]> wrote: > There will be an RFC meeting tonight about this: > https://phabricator.wikimedia.org/E148 > > One thing that I don't remember coming up during the summit is: > > Can we perhaps get all the people with +1 rights to use them and actually > review > stuff? So that people with +2 rights can look at things that already have > a +1, > and can thus avoid getting swamped with lots of patches with lots of low > grade > issues? > > Where would this idea fit into the zoo of tickets we have on the subject? > > Am 15.03.2016 um 17:11 schrieb Andre Klapper: > > Hey everybody! > > > > At the Wikimedia Developer Summit there was a session about "Making > > Code Review not suck" [1]. > > The outcome are Phabricator (sub)tasks of the task "Define potential > > actions to reduce code review queues and waiting times" in > > https://phabricator.wikimedia.org/T101686 > > > > The following potential actions items have been identified: > > > > * https://phabricator.wikimedia.org/T129842 : > > Decide whether to have a "Code Review" committee / working group > > * https://phabricator.wikimedia.org/T129067 : > > Agree on and document a structured, standardized approach for > > reviewing code contributions > > * https://phabricator.wikimedia.org/T129068 : > > Improve code contribution guidelines for patch authors > > * https://phabricator.wikimedia.org/T128370 : > > Update ownership list on [[mw:Developers/Maintainers]] > > * https://phabricator.wikimedia.org/T128371 : > > Set up Code Review office hours > > * https://phabricator.wikimedia.org/T128372 : > > Document use of Owners in Phabricator and advertise it > > * https://phabricator.wikimedia.org/T115852 : > > Fix unclear maintenance > > responsibilities for some parts of MediaWiki > > core repository > > > > Discussion on each of those proposals is welcomed in the corresponding > > tasks! > > > > Thanks, > > andre > > > > [1] https://phabricator.wikimedia.org/T114419 > > > > > _______________________________________________ > Wikitech-l mailing list > [email protected] > https://lists.wikimedia.org/mailman/listinfo/wikitech-l _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
