On 26/01/17 01:18, Erik Bernhardson wrote:
Noticed earlier today, because some code that had been deprecated since
1.21 was removed and starting causing fatals, that we don't log deprecation
notices in production. This has now been fixed.
Please check logstash for `channel:deprecated` and see if anything you are
reposinsible for is using hard-deprecated methods and fix them.
Some culprits which have each generated hundreds of messages in the ~5
minutes it's been turned on:
Use of SpecialRecentChangesQuery hook (used in
FlaggedRevsUIHooks::modifyRecentChangesQuery) was deprecated in MediaWiki
1.23. [Called from SpecialRecentChanges::runMainQueryHook in
/srv/mediawiki/php-1.29.0-wmf.8/includes/specials/SpecialRecentchanges.ph
<snip>
Thanks for the logging channel, that is going to be quite helpful. To
anyone spotting them, please fill corresponding tasks against the
appropriate extension/skin and add in #wikimedia-log-errors to the task.
There are a few things that puzzle me though:
We have CI running with $wgDevelopmentWarnings = true; which fails the
test whenever wfDeprecated() is invoked. But I guess lot of extension
code lack tests for those hooks.
We have a strict deprecation policy which ask for extensions to be
updated when a code is @deprecated. And removing code/hook must only be
made when we have verified that all extensions we host have been migrated.
https://www.mediawiki.org/wiki/Deprecation
Then mistakes happen :(
--
Antoine "hashar" Musso
_______________________________________________
Wikitech-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
