On Mon, Apr 17, 2017 at 3:07 PM Denny Vrandečić <vrande...@gmail.com> wrote:
> Ah, that's a good point! Sorry, stupid error. > > I think I did it now - adding to > mediawiki-vagrant/puppet/hieradata/common.yaml (I hope that is the right > approach). > > Now I get the following error, which seems unrelated to my extension. Hm. > > Apr 17 21:48:57 mediawiki-vagrant hhvm[29575]: #033[0m#033[22;31m[Mon Apr > 17 21:48:57 2017] [hphp] [29575:7ff81f7ff700:1:000002] [] Exception handler > threw an object exception: TypeError: Argument 5 passed to pfsockopen() > must be an instance of float, int given in > /vagrant/mediawiki/includes/libs/redis/RedisConnectionPool.php:233 > > That almost sounds like we should be casting the input to RedisConnectionPool to a float from an int. If it expects floats, easy enough to provide one...could just check with ctype_digit() so we can handle ints and strings that look like numbers. And probably throw an exception if we're not, it's probably bogus config or a bug if we're looking at non-numeric input. -Chad _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
