On Thu, May 4, 2017 at 5:14 PM, Legoktm <[email protected]> wrote:

> If you encounter any bugs or have suggestions on new rules, please reply
> to this thread or file a bug in the #MediaWiki-Codesniffer Phabricator
> project.
>

I ran this over a few repositories and ran into some issues.

   - "@param string $name" seems fine on a method like "getItemByName()",
   there's little point in making that "@param string $name The name"
   - It whines if PHP builtins aren't documented. Do we really need to
   document __toString() over and over again?
   - Doxygen is happy to inherit documentation from the parent class for an
   overridden method. Your phpcs check doesn't even honor @inheritdoc, it want
   everything copied.

At that point I gave up looking for wheat in the chaff.
-- 
Brad Jorsch (Anomie)
Senior Software Engineer
Wikimedia Foundation
_______________________________________________
Wikitech-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Reply via email to