-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Hi,

On 04/07/2018 09:03 PM, Kunal Mehta wrote:
> I'd like to start running voting tests against PHPUnit 4 and 6
> next week on Thursday (April 12). This should give us just enough
> time to fix any resulting issues before the 1.31 branch.

We ran into a few[1] issues today, but are all ready to merge the
upgrade to PHPUnit 6[2] tomorrow (Friday April 13). I suspect that
very few people actually tested their extensions against PHPUnit 6 -
so we'll just see what the fallout is and fix broken extensions as
they come up. Thanks to Anomie, James F, and Krinkle for addressing
failures and reviewing patches today, and Hashar for helping with
Jenkins :-)

So far the main problem areas that cause failures are:
* Using getMock/setExpectedException without the back-compat layer
* Trying to mock methods that no longer exist (or never did)
* Tests that don't assert anything and are risky

[1] https://gerrit.wikimedia.org/r/#/q/topic:phpunit-6
[2] https://gerrit.wikimedia.org/r/#/c/394851/

- -- Legoktm
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE+h6fmkHn9DUCyl1jUvyOe+23/KIFAlrQa70ACgkQUvyOe+23
/KLRYw/+J0rqRaYg7rLL2AYR8d5tgWYInwvL9slImSTswCmibwZ37hvzUz/siAq8
JwZJ93me+RNFWGPC4yKATOHXcqE/VnRKUeK4Mkm018T+4JHimzT2qxtZrh0y+QMW
7pweaTeHhGw7ElFIPGKtFZiVK+K9CQjk2d6yVx81/I3T97M+nnRwiquB7sSWazOo
HladVHYaC+MljbKMoIADbutf5w5X53BPtfuAz9FNeqV6Kf8xEWYlgjDqRC7+/V+h
CxgfdFQQXsmBgQ10mJPqJNOoulr5H1TmUNCABmYpbOExHS8wQoBLcljgPWBGjziY
TGkcjc2SHC38llgzVSxFC76Y4zLTgrqVVR5ouWcBhgAEEi8AA0DkVh4uBiG+UAPi
FvecaiiM6D++rvEvNNjp2v/bM1Fea/gpSV8Qoz7ZrmXhV0Tyg55zOyTOMe0SiC6z
k+pPkRzcJCvTAQU+OkCSqg8QofR5UIxiU32kHlTaV3TrbB/U7JDXERzCOmOTgTGS
2o92srqDdPVf9tHGB/a/ee3iao1+ajv5Lhzfn6B1pU2PLevr7+9EP57ZFdjAt/Yy
NcBRNGMRofRmIm2gxPXTvXrpKuLEesoXqonvmDy5gvSSx+xwkHq/HGkywp5myCaX
3u1zodAgY7aU7EChLi7dwTTnZBxG4Tn9Vrj4kASGs6YB/Y6ljYM=
=uNDm
-----END PGP SIGNATURE-----

_______________________________________________
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Reply via email to