-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Hi,
On 04/26/2018 12:02 PM, Daniel Kinzler wrote: > Hi all! > > While I think it's great that CI is making sure that test coverage > improves, I'm struggeling with making this work for me. It seems > to me the stats that are used to detect test coverage are faulty, > or at least unintuitive. > > See for instance <https://gerrit.wikimedia.org/r/c/423146/10>. > Please explain to me how this decreases test coverage > <https://integration.wikimedia.org/ci/job/mediawiki-phpunit-coverage-p atch/2480/console>. > > > > What am I missing? As far as I can see, all new code has tests. I'm havi ng > similar issues with several of my patches. Two files have less coverage than they did before your patch: +-------------------------------------------+--------+--------+ | Filename | Old % | New % | +-------------------------------------------+--------+--------+ | includes/Storage/RevisionSlots.php | 58.33 | 49.35 | | includes/Storage/SlotRecord.php | 94.64 | 94.51 | +-------------------------------------------+--------+--------+ The second one is probably unfair to complain on, but guessing by the percentage, the first one is likely a legitimate loss of test coverage. phpunit-patch-coverage will claim coverage is lower if any file decreases in coverage percentage. There's a pre-existing task called "phpunit-patch-coverage logic on when coverage goes down in one file and up for others needs improving"[1], which probably is what you're describing. Suggestions on how to handle these cases is welcome! [1] https://phabricator.wikimedia.org/T188687 - -- Legoktm -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE+h6fmkHn9DUCyl1jUvyOe+23/KIFAlriLqAACgkQUvyOe+23 /KJmBg/+IexdTh+TepaFpejFDnyqxcIQbFETBJKoC4r0G+YSd8LIu9KAY52Zc/uf OoeYNbT9z5eTqR1ckS95T3nVOF29y+Yylky1VX262vQaorEcPADtXAqglLCmRFg4 F/c4RdQdIABeagoYNivCO49pFA8tARKBoiJgQDR0CLoeh7Cs0VNoSfNnlTXdGduA o8R74ScOswbBfTsm3ybrfwuiKYADZOE1U51ftKeJmMRKoF9+lE9OiFfOF/iI4xNA SEXtyqgm9tJY2NqmVNkxUsAfcGa+sHKcBebiIkYxEoeV8Knjn3vs2n2jKJcssddO wQvDGv4N7XKieGcMxkM1SN36q4GCvOYFeQYh9FuScpW36XnGF8cHNtPel+CcFu52 IUGAeZMZ9FRQ2sjhDRCwxwFy1fDVy5Smnew4surmBWDzF6nrBGMEeq23DDknyx+U Lf2+1wqbhGmBdzW2c8cmhQOdrfkq9j9IFXHPqkhXC3k/FClKhn7bz9tPeVsPnFJX 16q6vBbln1ntPCJUTST7tlp3ciAoxj4r3gopwGdcDXNGf53BgKMa1YFQhWmqlx/D XASrc/8VCGRIsbPEMNcBmJs93eLvvL7UIOUcsJ2ouPqDb6G+brHyKanTfPUQwnvj i+KzYpdYUkH+6a5OAo2A09hDtx5ALmHH3pm+eKcRicG61OHBGHY= =uP+6 -----END PGP SIGNATURE----- _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
