-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Hi,
On 05/15/2018 11:25 PM, Jeroen De Dauw wrote: > Failing tests: > https://travis-ci.org/JeroenDeDauw/Maps/builds/375344161 > > Code: https://github.com/JeroenDeDauw/Maps OK, so you need to use the PHPUnit4And6Compat trait as explained in[1]. That polyfills the setExpectedException() method that was removed in PHPUnit 6. Since you want to support older MediaWiki versions that don't have the trait, if you write your tests expecting PHPUnit 4 and leave a dummy trait in place for older versions, it should work out. I submitted this as a PR at [2]. Whenever you stop testing against pre-1.31 versions of MediaWiki, you can drop the trait and write your tests expecting PHPUnit 6. That said, it looks like master of the Maps extension isn't actually running any tests against older versions of MediaWiki, they all seem to report "No tests executed!"[3]. > I'd be ideal to have the older versions of MediaWiki use PHPUnit > 6.x or later, but I've not found a way to do so yet. You'd have to backport the PHPUnit4And6Compat trait as well as the autoloader aliasing[4]. [1] https://lists.wikimedia.org/pipermail/wikitech-l/2018-April/089766.html [2] https://github.com/JeroenDeDauw/Maps/pull/424 [3] https://travis-ci.org/JeroenDeDauw/Maps/jobs/378261536 [4] https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/master/t ests/common/TestsAutoLoader.php#191 - -- Legoktm -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE+h6fmkHn9DUCyl1jUvyOe+23/KIFAlr86EIACgkQUvyOe+23 /KJ+MA/+KseYsMrpvAeQWBQq31I7WcGCQWHQGPNRrAQtnPIbIc+IlfoS3+wNmB/J m1TSSzj20pAtqwvGB/dJsoER/LJRKWdSXWeYSpKIm7xtEfK1qdVqSlbsgeHVBC+/ HnK6MRxExZwL1p0IpWsJIdt7q7+dIx7CBrVqOIe1f6DZRO+pKatZrTNiEUOAzawr GayLMFmL37J66sV/eMTTMB30iJJG3WZow0TvtHnhhTdl4f3jVFpQC2DVgSsGAKa0 x89G3gTOPo3kP+3wYt8T+2gO4li/V75RPdA2ZJnDCNDdwPoM3RDb+AnVTefSbTXS 0q5JITOvRzxb4kXiXDIEFv6DHuKhTjJMAQKBWj+cHbnZTXM0ot2HCEsAHMnyJggD p6xCP8y4EP8fu0dH5+bWhgcWKD8pr1kA2gMFHFmXVgc1dTVrH1L4n8VDIeJcX2IK Xp96GD4rSEC3hiZ0BJLrWSltFqQf5bj9HCqOmbkBRm85/cD0C+APferrfPr5USgV gqBf1vjjAoz76ctobqLG6eli6DRSjjIR5pqvNKkJyFA5vRt2uqWnCXownmHlCT/a HPYh2AmGK+NAJZKwDtYS9sPClQ671BlpeMOp94ASB24bKkOqyapPr5pu1hukN3oG z+kB+u5GP50dsXM03kq3h3+Ful62Etrnc6ydbilh5csZzgUREBs= =+jql -----END PGP SIGNATURE----- _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
