There have been several proposals for removal without deprecation in the past few days, each with more impact on existing code - from "virtually certain nobody ever used" to "the fix is trivial".
I know it is annoying as heck to keep outdated code, but if you ask me, unless there is an immediate compelling reason for the removal the deprecation policy should not be bypassed. And in my opinion "I did not find any extension that uses this method" is not sufficient. Not all extensions/skins are hosted on WMF servers. And being trivial to fix does not help, either. It would be great if everybody could monitor MW master, run CI tests regularly for all their extensions and fix any breakages. Unfortunately many people do not have the time to do that, so they need the deprecation period (and at times the deprecation popups to even notice that something is wrong). So, I would request to keep the clearCache() method for the foreseen deprecation period. (And generally speaking, though not explicitly required by the deprecation policy and probably not applicable in this instance, it would be great if deprecated methods would actually be kept in working condition and not reduced to a (literally) empty husk just to stay in line with the letter of the policy.) Stephan ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ On July 30, 2018 2:51 PM, Aryeh Gregor <[email protected]> wrote: > Patch to remove: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/447647 > Bug: https://phabricator.wikimedia.org/T200247 > Existing uses: > https://codesearch.wmflabs.org/search/?q=MagicWord%3A%3AclearCache&i=nope&files=&repos= > > I'm in the middle of creating a MagicWordFactory service to replace > the MagicWord static methods. This obsoletes the clearCache() method. > Instead, just reset the service with resetServiceForTesting(). Since > clearCache() is used in only three places in public code, and is only > useful to begin with for tests, and the fix is trivial, I propose > removing it without deprecation rather than bothering to maintain code > for compatibility. > > Wikitech-l mailing list > [email protected] > https://lists.wikimedia.org/mailman/listinfo/wikitech-l _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
