That has also be implemented upstream. Starting from 2.16.
https://github.com/GerritCodeReview/gerrit/commit/efc81216a1bffe599477cca32cf9d82307109ca9
On Thursday, 4 October 2018, 17:14:05 BST, C. Scott Ananian
<[email protected]> wrote:
The new Gerrit UI seems to be missing the "ignore whitespace" option in diffs
which the old Gerrit UI had. That's a very useful feature when reviewing
patches which include indentation changes, for example compare:
https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/463559/6/lib/wt2html/TokenTransformManager.js?polygerrit=1withhttps://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/463559/6/lib/wt2html/TokenTransformManager.js?polygerrit=0(after
setting "ignore whitespace" to "all" in the gear-shaped preference menu in the
top-right). --scott
On Wed, Oct 3, 2018 at 5:09 PM Paladox via Wikitech-l
<[email protected]> wrote:
Hi, i am collecting feedback for Gerrit's New UI called PolyGerrit. It's
possible to use PolyGerrit on gerrit.wikimedia.org since 2.14. The new UI has
recently been made the default upstream. The Old UI is going away in the next
release after 2.16. Upstream have given PolyGerrit another update that looks
different to the one on gerrit.wikimedia.org. PolyGerrit now includes a dark ui.
To switch to PolyGerrit either click the "New UI" button on the footer or put
?polygerrit=1 in the url.
To switch back to GWTUI either click "Switch back to old ui" on the footer or
put ?polygerrit=0 in the url.
Non dark mode:
Here's how it looks like:
Dashboard:
https://phabricator.wikimedia.org/F26296230
Change list:
https://phabricator.wikimedia.org/F26296240
Change screen:
https://phabricator.wikimedia.org/F26296242
https://phabricator.wikimedia.org/F26296257
Dark mode: https://phabricator.wikimedia.org/F26296282
And many other UI improvements across the app.
You can play around the the new ui from the master branch that will become 2.16
here https://gerrit.git.wmflabs.org/r/
Please give feedback so upstream can make PolyGerrit even better! You can
either file your reports at https://phabricator.wikimedia.org/project/view/330/
or reply to the email with your feedback.
It has a dedicated team on the UI with a design researcher behind the scenes
redesigning polygerrit constantly based on feedback.
_______________________________________________
Wikitech-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
--
(http://cscott.net)
_______________________________________________
Wikitech-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
