Summary of worst repos with more than one patch waiting:
5x WikiPEG. 4x Parsoid. 3x UnblockMe. 2x Cargo. 2x PageForms. 2x MW Core.


CR0: Please review and provide guidance if you are familiar with the
code, and decide (CR±1 or CR±2):


* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Cargo/+/480039/
** Added new feature: order virtual fields by the order they inserted to list 
on cargo store
** 2018-December-17
** Maintainers/Stewards: ???

* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Cargo/+/511394/
** Added 'bibtex' export format.
** 2019-May-24
** Maintainers/Stewards: ???

* 
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/GoogleAnalyticsMetrics/+/485488/
** fix: non-ascii page title bug
** 2019-January-20
** Maintainers/Stewards: Tosfos (as per Extension page)

* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/OdbcDatabase/+/487568/
** Fix OdbcDatabase to work under 1.32 and with current ExternalData
** 2019-February-02
** Maintainers/Stewards: ??? (Extension page says "Unmaintained")

* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Newsletter/+/501019/
** Hide View Source Tab in Newsletter namespace
** 2019-April-30
** Maintainers/Stewards: ??? (Unassigned)

* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/UnblockMe/+/508045/
** Edit Project Config
* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/UnblockMe/+/510791/
** Adding files
* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/UnblockMe/+/508047/
** Adding files
** Author is also extension author; author might need to get aware of
https://www.mediawiki.org/wiki/Gerrit/Privilege_policy#Requesting_Gerrit_privileges
 
or what's the policy on self-merging these days?

* https://gerrit.wikimedia.org/r/#/c/pywikibot/core/+/508092/
** remove dewiki archive template from edit restrictions
** 2019-May-05
** Maintainers/Stewards: ??? (not sure where Pywikibot lists that)

* https://gerrit.wikimedia.org/r/#/c/mediawiki/services/parsoid/+/508165/
** Make autolink matching more efficient
** 2019-May-06
** Maintainers/Stewards: Parsing Team

* https://gerrit.wikimedia.org/r/#/c/mediawiki/services/parsoid/+/508176/
** All NULL in flattenIfArray and remove superfluous return statements
** 2019-May-06
** Maintainers/Stewards: Parsing Team

* https://gerrit.wikimedia.org/r/#/c/mediawiki/services/parsoid/+/512628/
** cache rule generator optimization & formatting
** 2019-May-27
** Maintainers/Stewards: Parsing Team

* https://gerrit.wikimedia.org/r/#/c/mediawiki/services/parsoid/+/512632/
** cache rule generator clean-up 
** 2019-May-27
** Maintainers/Stewards: Parsing Team

* https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/507821/
** Modify "SiteExporter.php" and "SiteImporter.php" to handle "LanguageCode" 
property as well
** 2019-May-06
** Maintainers/Stewards: MediaWiki Platform Team

* https://gerrit.wikimedia.org/r/#/c/operations/mediawiki-config/+/508130/
** Create new http://www.mediawiki.org/xml/sitelist-1.1/ to reference 
sitelist-1.1.xsd
** 2019-May-07
** Maintainers/Stewards: MediaWiki Platform Team ?

* https://gerrit.wikimedia.org/r/#/c/operations/dns/+/508979/
** Revert "Convert most DYNA into 1H CNAME records"
** 2019-May-09
** Maintainers/Stewards: SRE

* https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/429533/
** ApiEditPage: Don't swap undo and undoafter parameters
** 2019-May-11
** Maintainers/Stewards: MediaWiki Platform Team

* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/PageForms/+/509629/
** Minimize multiple instance forms when using the Header Tabs extension
** 2019-May-13
** Maintainers/Stewards: ???

* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/PageForms/+/512642/
** Fix autocomplete filter function for no \w chars.
** 2019-May-27
** Maintainers/Stewards: ???

* https://gerrit.wikimedia.org/r/#/c/wikipeg/+/510070/
** WikiPEG character class optimization
** 2019-May-14
** Maintainers/Stewards: Parsing Team ?

* https://gerrit.wikimedia.org/r/#/c/wikipeg/+/510311/
** doc update
** 2019-May-27
** Maintainers/Stewards: Parsing Team ?

* https://gerrit.wikimedia.org/r/#/c/wikipeg/+/511820/
** Drop legacy & unused code (T224084). Avoid use of "discard" (T224085)
** 2019-May-22
** Maintainers/Stewards: Parsing Team ?

* https://gerrit.wikimedia.org/r/#/c/wikipeg/+/516455/
** chore: remove dead code and update .gitignore
** 2019-June-11
** Maintainers/Stewards: Parsing Team ?

* https://gerrit.wikimedia.org/r/#/c/wikipeg/+/516457/
** a-b benchmark tests
** 2019-June-11
** Maintainers/Stewards: Parsing Team ?

* 
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/ParserFunctions/+/511030/
** Introduce an additional parameter to #time and #timel functions to allow the 
wrapping of the result into <time> HTML tag
** 2019-May-20
** Maintainers/Stewards: Parsing Team

* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/VEForAll/+/513913/
** fix update all editors before save
** 2019-June-02
** Maintainers/Stewards: ???



CR+1: Please help make a decision (CR±1, CR±2) on these CR+1 patches:

* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/PipeEscape/+/486043/
** Convert PipeEscape to use extension registration
** 2019-April-20
** Maintainers/Stewards: ???

* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Push/+/492443/
** Use addJsConfigVars instead of addInlineScript
** 2019-April-09
** Maintainers/Stewards: ??? (mw.org says Unmaintained)



Read https://www.mediawiki.org/wiki/Gerrit/Code_review#By_project how
you can get notified of new patches in your code areas of interest.

Thanks in advance for your reviews!



Of last time's 10 listed patches, 
1 moved back from +1 to 0 (unreviewed);
1 got -1ed by Daimona Eaytoy;
2 got +2ed by Framawiki and Amire80;
1 got abandoned.



Maintainers/Stewards data taken from 
https://www.mediawiki.org/wiki/Developers/Maintainers
CR0 source: 
https://gerrit.wikimedia.org/r/#/q/ownerin:newcomers+status:open+label:Verified%253E%253D0+label:Code-Review%253D0
CR+1 source: 
https://gerrit.wikimedia.org/r/#/q/ownerin:newcomers+status:open+label:Verified%253E%253D1+label:Code-Review%253E%253D%252B1+-label:Code-Review%253C%253D0

-- 
Andre Klapper | Bugwrangler / Developer Advocate
https://blogs.gnome.org/aklapper/



_______________________________________________
Wikitech-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Reply via email to