On Tuesday 09 June 2009, Dan Williams wrote: > On Mon, 2009-06-08 at 18:00 -0700, Inaky Perez-Gonzalez wrote: > > On Monday 08 June 2009, Perez-Gonzalez, Inaky wrote: > > > Hi Guys > > > > > > Dirk and me finalized integrating the IRQ bootmode modifications today > > > and I did a final round of cleanups and pushed the new branch over to > > > the repository. This meant another rebase, but this should be one of > > > the last ones. > > > > Oops, sorry, wrong list...now you know which cleanups are in the pipeline > > for 2.6.31 :) > > cc639a57567d4f1cb55de0568f1d73c3a1fa98a6 wimax/i2400m: introduce module > parameter to disable entering power save > > Can we *not* resort to module parameters for this sort of thing? > modparams are almost always the wrong way to go about things. Or, if > you have to use module parameters, try to make sure they can be changed > on-the-fly at least?
This can be changed on the fly. I resorted to a module parameter because there is no standard way to ask this to a device. > Is the target of this debugging only, or is the > reason for it some problem you guys noticed and have kludged in a "try > loading wtih powersave disabled" workaround? Seems suspicious :) The whole reason for that patch to exist is to allow validation people to disable powersaving without having to kludge the code and as a (happy) consequence of it, it allows for a clean way to disable the device entering powersaving at all, which some setups need (one of my rigs does so). -- Inaky _______________________________________________ wimax mailing list [email protected] http://lists.linuxwimax.org/listinfo/wimax
