On 3/28/13 8:10 AM, Dmitry Timoshkov wrote: > Aric Stewart <a...@codeweavers.com> wrote: > >>>> Worked out with testing on Japanese windows XP. Resolves issues with >>>> keystrokes and accelerators in menus when the IME is active. >>> >>> You should really start adding the tests and base your patches on test >>> results instead of some sort of speculation. >>> >> I would love to add tests. But things like this require enough parts of >> things working in such a way that it was very hard if not impossible for >> me to think of a way to do it through an automated test for wine, let >> alone one that would run for windows. > > So, you admit that your IME patches are just a guesswork, i.e. you have > zero number of automated tests to check another guess? That's really > confusing. >
No. They are not guesswork. I wrote _interactive_ tests that I used on my windows machine to prove the behavior and this patch. It am was unable to make _automated_ tests that will in any meaningful way test the behavior. -aric
