> >     Serge Ivanov <?>
> >     LISTBOX_SetColumnWidth adds extra 2 pixels to the passed column width
> >     (it says it is for column margins). Obviousely it is wrong, because
> >     margins must be internal. It is easy to verify comparing rectangles
> >     passed in LPDRAWITEMSTRUCT (for ownerdraw listbox) in Windows and
> >     Wine. In Windows environment width of rectangle is the same as column
> >     width.
> 
> Is it a Wine bug ? or a remnant of the first implementation for 16 bits windows ?
> There is a warning about something like that in the developer's guide for win95.

I am not sure. It looks more like a remnant, the patch was this one:

Index: listbox.c
===================================================================
RCS file: /home/cvs/r/corelwine/controls/listbox.c,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -r1.10 -r1.11
--- listbox.c   2000/01/11 14:33:11     1.10
+++ listbox.c   2000/01/12 15:00:58     1.11
@@ -1096,7 +1096,6 @@
  */
 static LRESULT LISTBOX_SetColumnWidth( WND *wnd, LB_DESCR *descr, UINT width)
 {
-    width += 2;  /* For left and right margin */
     if (width == descr->column_width) return LB_OKAY;
     TRACE("[%04x]: new column width = %d\n",
                 wnd->hwndSelf, width );

Reply via email to