eric pouech wrote:
> just two comments (pure formalism, not on the API implementation itself)
>
> 1/ don't use C++ comments
Sorry, I usually use :/\/\/ in VI to find those before I send a real patch.
>
> 2/ (this is a larger problem) : Wine code used to access the i386
> context structs with macros (like EIP_reg(context)) because, at some
> point in time, there was no global definition of a i386 context (wine
> was using the one provided by the OS: Linux, BSD, Solaris, which defined
> fields with different names, hence the need of such macros). Now that a
> CONTEXT86 has been introduced, there is no need throughout the code to
> use those macros. (There's still one place were they could be used, in
> dlls/ntdll/signal???.c where we still get CPU contexts from the
> underlying OS).
>
Actually, I was using the original WINASPI code as an example, so I figured
(wrongly) that this was the correct way to do things. I'll change that and
repost the RFC.
-Dave
