Re: win95 style filedialog

[gerard patel]

At 03:26 PM 3/11/00 +0200, you wrote:
>Hi!
>
>Since I'm about to rewrite(*) large parts of the code are there any programs with 
>known problems? I would like to try to fix as much as possible.
>
>juergen
>
>(*) I tryed to fix some problems I found and I think the current code reached
>a state where its no more maintaible - the OnOpen function is probably the
>worst of all but I found a couple of potentially problems and bloated code in 
>some more functions.

There is a problem with templated file dialogs; you can see it in livepix
(www.livepix.com); when clicking a file in the list, an mini-picture of the file is 
supposed
to be displayed at the right of the dialog. I  had sent this patch to fix it, it was
ignored so the problem is still here.

Index: dlls/commdlg/filedlg95.c
===================================================================
RCS file: /home/wine/wine/dlls/commdlg/filedlg95.c,v
retrieving revision 1.24
diff -u -r1.24 filedlg95.c
--- dlls/commdlg/filedlg95.c    2000/02/10 22:15:21     1.24
+++ dlls/commdlg/filedlg95.c    2000/02/20 16:35:49
@@ -856,7 +856,11 @@
 
     default :
       if(uMsg >= CDM_FIRST && uMsg <= CDM_LAST)
-        return FILEDLG95_HandleCustomDialogMessages(hwnd, uMsg, wParam, lParam);
+      {
+        HRESULT hres = FILEDLG95_HandleCustomDialogMessages(hwnd, uMsg, wParam, 
+lParam);
+        SetWindowLongA(hwnd, DWL_MSGRESULT, hres);
+        return TRUE;
+      }
       return FALSE;
   }
 }          

My  guess is that this handling should be done for the other cases, but as I had  no 
time
to write test programs, I just patched where I saw a problem.

There is also this funny problem  (IIRC it was with a buggy program of
my own) :

@@ -1458,13 +1462,6 @@
          strncpy(fodInfos->ofnInfos.lpstrFileTitle,
                          lpstrFileSpec,
                          fodInfos->ofnInfos.nMaxFileTitle);
-
-      /* Check if the file is to be opened as read only */
-      if(BST_CHECKED == SendDlgItemMessageA(hwnd,
-                                           IDC_OPENREADONLY,
-                                           BM_GETSTATE,0,0))
-         SetFileAttributesA(fodInfos->ofnInfos.lpstrFile,
-                            FILE_ATTRIBUTE_READONLY);
 
       /*  nFileExtension and nFileOffset of OPENFILENAME structure */
       lpstrTemp = strrchr(fodInfos->ofnInfos.lpstrFile,'\\');           

Nice to see the choosen file turning read-only mysteriously (leading to other
failures,of course :-))

Good luck.

Gerard