gerard patel wrote:

> Maybe it would be a good thing to add some test for too big values in
> dump_bytes if the ultimate reason for the crash can't be fixed.

Did this patch never get in? I'm still in windows : ( so I can't check.

Joshua
--- server/trace.c.old  Thu Mar  9 16:24:53 2000
+++ server/trace.c      Thu Mar  9 16:24:01 2000
@@ -19,7 +19,7 @@
 static void dump_ints( const int *ptr, int len )
 {
     fputc( '{', stderr );
-    while (len)
+    while (len > 0)
     {
         fprintf( stderr, "%d", *ptr++ );
         if (--len) fputc( ',', stderr );
@@ -30,7 +30,7 @@
 static void dump_uints( const int *ptr, int len )
 {
     fputc( '{', stderr );
-    while (len)
+    while (len > 0)
     {
         fprintf( stderr, "%08x", *ptr++ );
         if (--len) fputc( ',', stderr );
@@ -41,7 +41,7 @@
 static void dump_bytes( const unsigned char *ptr, int len )
 {
     fputc( '{', stderr );
-    while (len)
+    while (len > 0)
     {
         fprintf( stderr, "%02x", *ptr++ );
         if (--len) fputc( ',', stderr );

Reply via email to