On Fri, May 19, 2000 at 06:07:39PM +0200, Patrik Stridvall wrote:
> > Same goes with the Win32 debug string functions.
> > IMHO they are quite important.
> 
> I agree.
> 
> > But nonetheless they are completely silenced right now
> > ("don't annoy the user").
> 
> Indeed, but some application might legally use NULL
> values, and we don't want a lot of bogus bug reports.
> Beside WARN is turned off by default, it is supposed
> to be use it for these kind of problems, so please use it.
No, not for *these* kind of problems.
In OutputDebugStringA():
    req->length  = (lstrlenW(str) + 1) * sizeof(WCHAR);
    server_call_noerr( REQ_OUTPUT_DEBUG_STRING );
    TRACE("%s\n", debugstr_w(str));
    ^^^^^
That should be a WARN() !!
That way one just enables warn+all when problems appear and everything
is settled.

I'll submit a patch soon.

Andreas Mohr

Reply via email to