> This is my first patch. If I am doing something wrong, chalk it up to
> ignorance and tell me.
Looks good in general, but a few comments.
First of all WineLib suppport for Win16 has been discontinued
for quite some time, because:
1. It is difficult for us to support and it is impossible
to do so prefectly without special compiler support,
because of memory layout issues. For example Win16 int
is 16-bit and data is aligned 16-bit.
2. It is in almost all cases easier to port a
Win16 application to Win32.
In short, unless a company says, oh we have this
very big Win16-only application that we tried to port to
Win32 and it didn't work very well because of all these
type size and alignment issues, can you (CodeWeaver or
somebody else) make this work with Wine, we are prepare
to pay quite a lot of money for it, it isn't going to
happend.
However since it _always_ will be easier and cheaper
making the Win16 binary run under Wine, I predict
that is never going to happend, especially since,
as I said earlier, that the C compiler (GNU C) need
to be fixed to support this as well.
Regardless, I'm not sure we want such an hack in the
main Wine tree.
A minor detail, I personally would prefer that Wine and WineLib
was always used in the uppercase W and uppercase L variant,
instead of, as in your document, sometime one variant, sometimes
another.
