> line 845:
> since hr = E_INVALIDARG at the initialization, if SHGetSpecialFolderPathA
> fails the returnvalue is already E_INVALIDARG in this case.
Well, kinda. Look at the non-default cases in the case statement. They set "hr =
NOERROR",
regardless of the return values. This is what was causing the problem for me. It was
trying to do a _ILCreateControl(), failing, but returning success. This definitely has
to
be fixed.
> [snip]
>
> Both failures are looking like a much more serious problem not to be cached
> by a simple NULL-check at this point. We would just hide problems instead of
> solving these. Do you have any debug-traces showing such a problem?
I just noticed this code and put the "if" there for safety's sake, not because I
encountered a problem. I don't care if it's there or not.
Henning
