On Mon, 24 Jul 2000, James Hatheway wrote:
> Unfortunately I don't have access to other build environments such as
> FreeBSD, Solaris, etc.
If you're interested, we surely can arrange for an account on a FreeBSD
box somehow! ;-)
> So I will ask Alexandre to please retract my patch from CVS, and I
> will submit a patch later today that fences off my patch with an
> '#ifdef linux' (which I have seen done in other places in the code)
Thanks for your quick response!
I believe we should avoid #ifdef linux whereever possible, because on
the one hand even different versions of the Linux kernel or different
distributions may behave differently (in general), and on the other hand
it makes the code less portable and reduces the incentive to improve
portability -- something which Ulrich, Patrik and myself (to a much
lesser degree) and probably others have been working on.
The Right Thing[TM], is to add autoconf and #ifdef feature checks in
the code, that's what we do -- rather successfully -- with GCC, which
is probably one of the largest non-trivial portable programs available.
On Mon, 24 Jul 2000, Patrik Stridvall wrote:
> I have fixed/kludged it on Solaris. Patch attached.
Great. Thanks!
> Both dlls/winsock/socket.c and dlls/wsock32/socket.c failed on Solaris.
> Both are fixed in this patch.
Your patch for Solaris also fixes dlls/winsock/socket.c for me! :-)
dlls/wsock32/socket.c, we'll have to investigate...
Gerald
--
Gerald "Jerry" [EMAIL PROTECTED] http://www.dbai.tuwien.ac.at/~pfeifer/
