Thanks. I did a cvs diff, and have updated my ~/.cvsrc with diff -u. Is this wrong or
are you implying I did the right thing?
I also have another set of patches for:
o Enhanced 'if' support
o Use of PATHEXT env var (NT) - eg. run file with non-normal extension
if allowed through pathext
o Better searching of path for these files
o Support of .cmd as extension for batch (NT allows this)
o Support for %* as a batch option
o Lookup in registry for filetype to see how it should be launched (HKEY_CLASSES_ROOT,
then its name, getting shell->open->command and lauching the appropriate program).
I thought I'd wait until my first patch 'passed' before submitting any more. If you
want them, email me.
Regards,
Jason
----- Original Message -----
From: Dave Pickles <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
Sent: Sun, 30 Jul 2000 18:21:38 +0100 (GMT+01:00)
Subject: Re: WCMD: Better batch support
> On Sun, 30 Jul 2000, Jason Edmeades wrote:
> >Hello,
> >
> >Please bear in mind this is my first ever attempt at any wine
> >programming, and
> >certainly my first ever patch, so please let me know if there is
> >anything I
> >should have done differently:
> >
> >Changes:
> >1. Make wine honour a comspec env var set up in wine.conf
> >2. Changes to wcmd for better batch support:
> > - Support whitespace around commands better, and support the @
> >prefix better
> > - Enhance the set support to unset, display value error correctly
> > - Enhance the command line support for parms, and env var expansion
> > - Enhance the echo command to not loose whitespace, and display
> >output with
> > % signs better
>
> Patches created using diff -u are preferred I believe - they're easier to
> understand by eye if nothing else.
>
> The changes look good. I have a couple more to submit in the next few days
> (when I finally fix the FormatMessage() stuff); an implementation of the
> ERRORLEVEL concept and a change to COPY to do the Right Thing when the
> output specifier is a directory.
>
> Dave Pickles
>
____________________________________________________________
Freeserve - get your free ISP service including web-mail at:
www.freeserve.co.uk