I'm sending this to the list to avoid similiar breakage in the future.
(Andreas, I don't mean to bash you, this is really just intended as a
warning for others.)

Please be *very* careful when removing #include <sys/types.h>! On non-
Linux systems this is usually needed in the presence of many system
headers.

In particular, the following patch broke FreeBSD 4.1:

  revision 1.74
  date: 2000/08/26 20:31:49;
  Andreas Mohr <[EMAIL PROTECTED]>
  - made the MIDI sequencer error message much better for confused users
    to be found on #WineHQ
  - use strerror instead of errno at important places
  - got rid of HAVE_STRERROR macro
  - removed some #include:s (hopefully I didn't break anything)

Fixed by the patch below.

Gerald

ChangeLog:
  We do need to #include <sys/types.h> on non-Linux platforms.

Index: pe_image.c
===================================================================
RCS file: /home/wine/wine/loader/pe_image.c,v
retrieving revision 1.75
diff -u -3 -p -r1.75 pe_image.c
--- pe_image.c  2000/08/28 21:33:28     1.75
+++ pe_image.c  2000/08/29 16:07:47
@@ -23,6 +23,7 @@
  *   NE_MODULE.module32.
  */
 
+#include <sys/types.h>
 #ifdef HAVE_SYS_MMAN_H
 #include <sys/mman.h>
 #endif

Reply via email to