Jason Mawdsley wrote:
>
> Hi Susan!
>
> This patch addressed exactly some of the problems I was experiencing with my
> app I am working on.
Hello Jason,
glad to hear it :)
> Unfortunately it introduces some other bugs like:
> - the buttons being left in raised conditions, when the menu is open
> - the button going back to normal when the mouse leaves the toolbar area
> even though the menu is still open.
yes, restoring the hot button in LButtonUp messed up our menu btns
too. i was afraid of messing up some app that needed it, so was
going to do more investigation before submitting a patch to remove
it. removing the last button pressed code from MouseLeave doesn't
adversely affect our app, either.
>
> So I decided to take your patch and improve upon it, here is my result.
> Fixed hot button issues, and made the toolbar mimic windows behavior more
> correctly.
>
> This is a replacement for Susan's patch.
looks good to me.
> Change log
> dlls/comctl32/toolbar.c
>
> Jason Mawdsley
> Macadamian Technologies
>
> PS Thanks for the patch Susan! ;-)
>
> ----- Original Message -----
> From: "Susan Farley" <[EMAIL PROTECTED]>
> To: "wine patches" <[EMAIL PROTECTED]>
> Sent: Friday, October 20, 2000 10:55 AM
> Subject: mouseleave on toolbar buttons
>
> > In addition to not allowing tool buttons to appear highlighted
> > (hot) when the enable flag is toggled, this patch corrects a
> > problem that was introduced by my CaptureChanged handler a couple
> > of weeks ago. Its purpose was to fix the condition where pressing
> > a tool button then releasing it outside of the btn put it in a
> > pressed state next time the mouse was moved over it. This is
> > a better way of doing it.
> >
> > :) sue
> >
> >
> > changelog:
> > * newly dis/enabled btns cannot be hot
> > * LButtonDown handlers for the app can cause the btn to lose
> > capture, (e.g. btns that drop down menus) so instead of using
> > WM_CAPTURECHANGED to reset nButtonDown for btns that have been
> > pressed then released outside of the btn's area, do it in
> > MouseLeave
>
> ------------------------------------------------------------------
> Name: whqtoolbarfix.diff
> whqtoolbarfix.diff Type: Plain Text (text/plain)
> Encoding: quoted-printable
