Hi! :)
 
The X11DRV_DrawArc() helper function is used to draw arcs, pies and chords.
Now when there is an open path, the lines and arcs used in these figures have 
to be added to this path (NT/2000.) This has not yet been implemented in wine 
for pies and chords. In the helper function the coordinates for the figure 
parts are calculated. So, it would be possible to add the required path 
entries from there. But I don't think graphics drivers should have anything 
to do with paths, just with drawing graphics primitives. But if the path 
entries aren't added from here, the coordinates for the entries have to be 
calculated somewhere else also ( or be passed in some way. ) A cleaner 
approach to this I think would be to move the calculation of the coordinates 
out of the graphics driver and into a helper function for WINAPI Arc(), Pie() 
and Chord(). Checking for open paths and taking the appropriate actions is 
now easily done at this level. This would also make for a simpler graphics 
driver, as the coordinate calculations are now done elsewhere. 

Is there a reason why this would not be a good approach ?


-- 
Mark Dufour <[EMAIL PROTECTED]>
Kascade <[EMAIL PROTECTED]>


Reply via email to