Joerg Mayer <[EMAIL PROTECTED]> writes:
> I basically renamed the i -> n to make sure that I have definitely looked
> at all instances of the variable. In at least 1 case adding a new variable
> was actually necessary. It is just an aid for me, so if you want, I can
> rename them back before actually sending further patches. Just tell
> me.
Yes please.
> To the second comment: I would never add "unnecessary" type casts :-)
> but that's based on my very limited programming experience. If you have
> something specific in mind, please let me know.
There may be a few cases where a type cast may actually make a
difference; but when the only difference is the warning I consider the
type cast unnecessary. And if the choice is between having warnings
with -W or having type casts all over the place, I prefer the
warnings.
--
Alexandre Julliard
[EMAIL PROTECTED]