Hi,

It seems that when applying the patch, Alexandre added:
#include <stdio.h>

to include the definition of snprintf, which was the cause of a warning 
(implicit declaration) in the original patch. I'll fix it for now by renaming 
fpos_t, since its only used internally. The crtdll stuff should avoid 
bringing in standard headers where possible, but until we bring in some 
MS-compatable headers to Wine (when MSVCRT start getting implemented), its 
sometimes hard to avoid clashes.

I'll roll the fix into another patch I have coming in an hour or two, for 
now its safe to ignore the warning.

Cheers,
Jon

On Tuesday 12 December 2000  8:28 pm, you wrote:
> Hi all,
>
> this is not good:
>
> gcc -c -I. -I. -I../../include -I../../include  -g -O2 -Wall -W
> -fno-strength-reduce -mpreferred-stack-boundary=2 -fPIC -D__WINE__
> -D_REENTRANT  -o locale.o locale.c In file included from locale.c:43:
> /usr/include/stdio.h:73: conflicting types for `fpos_t'
> crtdll.h:206: previous declaration of `fpos_t'
>
> andi@amohr:/usr/local/src/wine$ dpkg -l|grep libc6-dev
> ii  libc6-dev      2.2-5          GNU C Library: Development Libraries and
> Hea
>
> crtdll.h:
> typedef long fpos_t;
>
> stdio.h:
> /* The type of the second argument to `fgetpos' and `fsetpos'.  */
> #ifndef __USE_FILE_OFFSET64
> typedef _G_fpos_t fpos_t;
> #else
> typedef _G_fpos64_t fpos_t;
> #endif
> #ifdef __USE_LARGEFILE64
> typedef _G_fpos64_t fpos64_t;
> #endif
>
> Line 73 seems to indicate that it uses the first fpos_t definition.
>
> We might want to put an ifndef around our crtdll stuff, I guess.
>
> Andreas Mohr

-- 
"May their negative actions ripen upon me. And may all my virtues ripen upon 
them."
"If it could be talked about, everybody would have told their brother."
[EMAIL PROTECTED] , [EMAIL PROTECTED]


Reply via email to