---------- Forwarded message ----------
Date: Sun, 17 Dec 2000 00:42:28 -0200
From: Sandro Alves de Souza <[EMAIL PROTECTED]>
To: Wine administrator <[EMAIL PROTECTED]>,
James Juran <[EMAIL PROTECTED]>
Subject: Some errors found in safearray.c
Hi there !
I'm a brazilian programmer (27 years old), and I'd found some errors
in the file "wine-20001202/dlls/oleaut32/safearray.c".
My natural language is brazilian portuguese, so on,
I'm sorry if I'd maked any mistake, ok ?
I saw some errors in my windows applications that use variant arrays.
A "index out of bounds" error message always appears when any
element of a variant array had been accessed.
I'd opened the source file "safearray.c" in "wine-20001202/dlls/oleaut32"
and I'd found some errors in that code.
The errors found are :
1 - In the "SafeArrayGetUBound" and "SafeArrayGetLBound" functions.
1.1 - The dimension number check is performed only for values above the high limit,
but not for values under the low limit (always 1).
Where appears : if(nDim > psa->cDims)
return DISP_E_BADINDEX;
Should be : if((nDim < 1) || (nDim > psa->cDims))
return DISP_E_BADINDEX;
2 - In the "validCoordinate" function.
2.1 - The dimension number for the "SafeArrayGetUBound" and "SafeArrayGetLBound" functions
is wrongly specified. The first specified dimension was 0 (zero) and not 1.
When appears : if((hRes = SafeArrayGetLBound(psa, iter, &lLBound)) != S_OK)
return FALSE;
if((hRes = SafeArrayGetUBound(psa, iter, &lUBound)) != S_OK)
return FALSE;
Should be : if((hRes = SafeArrayGetLBound(psa, iter + 1, &lLBound)) != S_OK)
return FALSE;
if((hRes = SafeArrayGetUBound(psa, iter + 1, &lUBound)) != S_OK)
return FALSE;
I'd maked these corrections in the wine code of my machine and after it i'd recompiled the code.
After it, my windows applications are working fine now.
So on, I sent you this email to inform you about these errors.
I'm very much surprised by your (everybody of project) fine work in the wine project.
To run windows applications in Linux without source modifications or any kind of changing,
without to use any kind of interpreter, to run a windows application in Linux "as it is"
is the dreaming of every windows developers (as me !).
I congratulate everybody of this fantastic project, and I hope it email help you, some way.
Thank you very much for your attention, and good work !
Note : The previous email have a wrong email address to me, my email address is [EMAIL PROTECTED]
new-safearray.zip- Re: Some errors found in safearray.c (fwd) Ove Kaaven
- Re: Some errors found in safearray.c (fwd) Ove Kaaven
