> From: "Rolf Kalbermatter" <[EMAIL PROTECTED]>
> To: <[EMAIL PROTECTED]>
> Subject: shell32: SHChangeNotify is really Unicode/ANSI indifferent
> Date: Mon, 20 Jan 2003 21:53:34 +0100
> Reply-To: [EMAIL PROTECTED]

<snip>

> -/****************************************************************
> *********
> - * SHChangeNotify                            [SHELL32.@]
> - */
> -void WINAPI SHChangeNotifyA (LONG wEventId, UINT  uFlags,
> LPCVOID dwItem1, LPCVOID dwItem2)
> +void WINAPI SHChangeNotify(LONG wEventId, UINT uFlags, LPCVOID
> dwItem1, LPCVOID dwItem2)

<snip>

> +     else if (uFlags & SHCNF_PATHW)
> +     {
> +       DWORD dummy;
> +       if (dwItem1) SHILCreateFromPathW((LPCSTR)dwItem1,
> &Pidls[0], &dummy);
> +       if (dwItem2) SHILCreateFromPathW((LPCSTR)dwItem2,
> &Pidls[1], &dummy);
> +     }
> +     else if (uFlags & (SHCNF_PRINTERW || SHCNF_PRINTERW)

There seems to be something strange with the line above (SHCNF_PRINTERW ||
SHCNF_PRINTERW) == SHCNF_PRINTERW. Should this be (SHCNF_PRINTERW ||
SHCNF_PRINTERA) by any chance?

> +     {
> +       FIXME("SHChangeNotify with (uFlags & SHCNF_PRINTER)");
>       }

Other than that, good work!

Rob



Reply via email to