On March 15, 2003 04:22 pm, Lionel Ulmer wrote:
> Just to nitpick, in most of your patches, you have this :
> > if (TRACE_ON(ddraw)) {
> > - DPRINTF(" Real caps are : "); DDRAW_dump_DDSCAPS2(&our_caps);
> > DPRINTF("\n");
> > + TRACE(" Real caps are : "); DDRAW_dump_DDSCAPS2(&our_caps); TRACE("\n");
>
> As we use 'TRACE' now and not 'DPRINTF', the 'TRACE_ON' constructs could be
> removed.
This is why I said these needs manual review, so we can eliminate
this type of tests. But personally I would have liked it a lot more
if you could code these like so:
if (TRACE_ON(ddraw)) {
- DPRINTF(" Real caps are : "); DDRAW_dump_DDSCAPS2(&our_caps);
DPRINTF("\n");
+ TRACE(" Real caps are : %s\n", debugddscaps2(&our_caps));
That's what I did in listview.c, and the code looks a lot neater IMO.
But then again, maybe that's just me.
--
Dimi.
