Le jeudi 23 dÃcembre 2004 Ã 22:39 +0100, Paul van Schayck a Ãcrit :
> Hey Eric,
>
> On Thu, 23 Dec 2004 01:38:02 -0800 (PST), Eric Blade <[EMAIL PROTECTED]>
> wrote:
> > The attached patch includes a lot of cleaning up,
> > mostly to HTML, a bit to some PHP.
>
> What's this supposed to do:
> if(!$tempResult)
> {
> - echo "$query <br>\n";
> + echo "$query <<br />>\n";
> echo "An error occurred: ".mysql_error()."<p>";
> exit;
> }
> @@ -68,7 +68,7 @@
> if(debugging())
> {
> echo $query;
> - echo "<br><br>";
> + echo "<<br />><<br />>";
> }
>
Same question: what are those <<br />> ???
> And:
>
> -if(!loggedin())
> +if(!loggedin() || (!havepriv("admin"))
If you are not loggeddin() you can't havepriv("admin") btw
So we have:
_old version_
C=A
A=TRUE => C=TRUE
A=FALSE => C=FALSE
_your version_
C=(A OR B)
A=TRUE => B=TRUE => C=TRUE
A=FALSE, B=TRUE => C=TRUE
A=FALSE, B=FALSE => C=FALSE
So your version doesn't mean the same as the old one, is that correct ?
If it is what we need, why don't you simple use:
if(!havepriv("admin"))
C=B
B=TRUE => C=TRUE
B=FALSE => C=FALSE
Which means the same as your version.
>
> Shouldn't this be
> if(!loggedin() AND (!havepriv("admin"))
C=(A AND B)
A=TRUE => B=TRUE => C=TRUE
A=FALSE, B=TRUE => C=FALSE
A=FALSE, B=FALSE => C=FALSE
So this version means the same as the old one but then why do we make it
more complicated ?
signature.asc
Description: Ceci est une partie de message =?ISO-8859-1?Q?num=E9riquement?= =?ISO-8859-1?Q?_sign=E9e?=
