Re: GetOpenFileNameA has trouble with UTF-8 locale and UTF-8 encoded pathname

[Michael Jung]

Hi,

On Monday 21 November 2005 18:38, Alex Villací­s Lasso wrote:
> I was rather hoping for an explanation of which is the "correct"
> behavior for an UTF-8 locale:

Sorry. I guess I'm not that competent when it comes to character encoding 
stuff. But then, Alexandre and Troy already answered your question already 
anyway.

On Monday 21 November 2005 20:54, Alexandre Julliard wrote:
> Asian locales will use one of the double-byte codepages.

Are you saying that on an asian system CP_ACP is actually a double byte 
encoding? Is anybody on the list using an asian locale on her system? Does it 
break the unixfs extension?

Alex, could you please try if the attached patch fixes the problem?

Bye,
-- 
Michael Jung
[EMAIL PROTECTED]

Index: dlls/shell32/shfldr_unixfs.c
===================================================================
RCS file: /home/wine/wine/dlls/shell32/shfldr_unixfs.c,v
retrieving revision 1.60
diff -u -p -r1.60 shfldr_unixfs.c
--- dlls/shell32/shfldr_unixfs.c	5 Nov 2005 10:44:28 -0000	1.60
+++ dlls/shell32/shfldr_unixfs.c	22 Nov 2005 08:25:08 -0000
@@ -1003,8 +1003,8 @@ static HRESULT WINAPI UnixFolder_IShellF
                 if (!pwszDosPath)
                     return HRESULT_FROM_WIN32(GetLastError());
                 PathRemoveBackslashW(pwszDosPath);
-                WideCharToMultiByte(CP_UNIXCP, 0, pwszDosPath, -1, lpName->u.cStr, MAX_PATH, NULL, NULL);
-                HeapFree(GetProcessHeap(), 0, pwszDosPath);        
+                WideCharToMultiByte(CP_ACP, 0, pwszDosPath, -1, lpName->u.cStr, MAX_PATH, NULL, NULL);
+                HeapFree(GetProcessHeap(), 0, pwszDosPath);     
             }
         } else {
             IShellFolder *pSubFolder;