Thomas Weidenmueller wrote:

P.S.: Please let me know if there's something wrong with this patch or
tell me why it was rejected. Otherwise I'm going to assume the fixes
aren't appreciated or necessary because the implementation is considered
mature and stable.

../../../tools/runtest -q -P wine -M shell32.dll -T ../../.. -p shell32_test.exe.so shelllink.c && touch shelllink.ok
fixme:shell:ShellLink_GetFlags 0x7fd3f7b0 0x7fb5f8b0
fixme:shell:ShellLink_GetFlags 0x7fd3f7b0 0x7fb5f8b0
shelllink.c:576: Test failed: CopyDataBlock failed
shelllink.c:578: Test failed: signature wrong
shelllink.c:579: Test failed: signature wrong

You might want to split the patch into three separate changes (header + clist fixes + shelllink) too.

Mike


Reply via email to