On 8/23/06, Michael Stefaniuc <[EMAIL PROTECTED]> wrote:
> + /* start table off small to avoid hiding resize bugs */ > + msihandletable_size = 1; Isn't this very small start value something to be used only for debugging while one writes the resizing code? For "production" I would use a value that is big enough to handle the common case (handles at least 50% of the real life cases).
OK, once wine hits 1.0 and is in production, let's go back and do that. Seriously, what's the disadvantage to keeping the initial size small? The overhead of six realloc's is utterly insignificant, and there's a fairly good chance somebody will get the locking wrong in an update to that code, so making the reallocs happen in the common case is a *good* thing that will help guard against bugs. - Dan
