Stefan Leichter wrote:
Am Monday 13 August 2007 13:28 schrieb Paul Vriens:
Stefan Leichter wrote:
Am Friday 10 August 2007 12:15 schrieb Paul Vriens:
Hi,
I just want to get people's opinion(s) about the
needs/requirements/whishes for both the conformance tests themselves
(including winetest) as well as the webpages.
I'll collect the information and will put it on the wiki.
Cheers,
Paul.
What about marking the "todo_wine" on the web page somehow?
Bye Stefan
Hi Stefan,
todo_wine will only be present on a Wine testrun. Results for each test are
available (including todo) when you hover over the single results.
We can of course use a general 'todo' visualization but who do you like to
see that?
Or was you're idea to show todo_wine's in Windows results !?
Cheers,
Paul.
Some days ago i had an issue with an installer. I remembered that i had this
long time ago and that i wrote a test to document the difference and a patch
to fix the issue. Only the test was accepted not the patch.
Having the todo_wine on the test result page might have saved me some time
digging through the ChangeLog files.
Also it someone is locking for something todo, he can look to the test results
and see the known issues. I don't thing all issues are all documented in
bugzilla.
Bye Stefan
Hi Stefan,
I've been playing a bit with have the 'todo_<platform>' on the page. In theory
it's possible that there are todo_<platform>'s that why I don't refer to
todo_wine.
On http://www.xs4all.nl/~pvriens/200708181000_orig/ you can see the current
situation for some random test results.
On http://www.xs4all.nl/~pvriens/200708181000_with_todo/ I've added a column
with todo's if one or more tests have a todo_item. This todo columns will only
be present in the main summary and shows the maximum number of todo's for that
test for that platform.
I've tried adding the todo information to the current table cells but didn't
find a satisfactory (that is nice looking) way. This is especially true for
tests that also have a skip.
As said before in theory we could have todo's for several platforms and
different todo results per test. In practice we will only have todo_wine's and
the number of todo's per test will be the same.
Needless to say that for this to work we need people to run tests on Wine and
have the reports sent in.
Let me know what you think of it. (the patch to 'gather' is attached).
Cheers,
Paul.
--- /wine/tools/winetest/gather 2007-08-16 09:14:14.000000000 +0200
+++ gather.paul 2007-08-20 08:47:07.000000000 +0200
@@ -112,6 +112,14 @@ foreach my $file (glob "$datadir/$build/
} else {
$group->{extrema}->{$testname} = [$error, $error];
}
+
+ if ($todo > 0) {
+ if (defined $group->{todo}->{$testname}) {
+ $group->{todo}->{$testname} = $todo if $todo > $group->{todo}->{$testname};
+ } else {
+ $group->{todo}->{$testname} = $todo;
+ }
+ }
} elsif ($todo eq "crash") {
$testref->{crash} = $testname;
} elsif ($todo eq "filelimit") {
@@ -173,6 +181,9 @@ foreach (@groups) {
<a href=\"$test->{dir}/report\">[file]</a></small></th>
EOF
}
+ if (exists $_->{todo}) {
+ $header .= " <th>$_->{name}<br><small>todo</small></th>\n";
+ }
}
}
chop $header;
@@ -280,6 +291,7 @@ EOF
}
}
+# Create the summary
foreach my $testname (sort keys %alltests) {
print OUT <<"EOF";
<tr>
@@ -307,6 +319,18 @@ EOF
print OUT " <td class=\"note\"><a $href>.</a></td>\n";
}
}
+ if (exists $group->{todo}) {
+ if (exists $group->{todo}->{$testname}) {
+ my $testtodo = $group->{todo}->{$testname};
+ print OUT <<"EOF";
+ <td class="todo"><a href="$alltests{$testname}"
+ title="There are $testtodo todo items reported for $group->{name} in this test"
+ >$testtodo</a></td>
+EOF
+ } else {
+ print OUT " <td class=\"todo\"></td>\n";
+ }
+ }
}
print OUT " </tr>\n";
}
