"Saulius Krasuckas" <[EMAIL PROTECTED]> wrote: > No, he did not. The word "need" wasn't appropriate here. Christopher > wasn't going to change LoadStringA. If changes of LoadStringW breaks > LoadStringA then tests would show regression. If tests are too weak, then > only patch commiter or previous patchers of the LoadStringA are to blame, > not the casual contributor who enhances B.
It should be obvious that if a patch introduces a regression (which is the case) then this patch can't be aplied. If the regression can be identified by someone able to read the code and not by a regression test that doesn't matter. > P.S.: James, you probably should start learning to cut unnecessary blocks > of quoted text (esp. empty lines) and doing some block justifying in your > replies using your MUA some day. Otherwise it gets too hard to read a > discussion. James left the useful context which is especially helpful for you to reply in 2 weeks without need to reread the whole thread. -- Dmitry.
