On Thursday 01 May 2008 08:30:40 James Hawkins wrote: > + /* get new psc */ > + hr = ScriptPlace(hdc, &psc, pwOutGlyphs1, pcGlyphs, psva, > &pItem[0].a, piAdvance, > + pGoffset, pABC); > + ok (hr == 0, "Should return 0 not (%08x)\n", hr); > + ok (psc != NULL, "psc should not be NULL\n"); > /* Set that is gets a psc and that returns 0 status */ > hr = ScriptTextOut(hdc, &psc, 0, 0, 0, NULL, &pItem[0].a, NULL, > 0, pwOutGlyphs1, pcGlyphs, > piAdvance, NULL, pGoffset);
test.winehq.org shows that this ScriptTextOut test fails on all versions of Windows and succeeds on Wine, so a better fix would be to reverse the check for psc and make Wine pass the test. The fix depends on Guy Albertelli's recent fix for ScriptTextOut, I'll send a patch after that one has been committed. -Hans
