> + if (Usage & WINED3DUSAGE_DYNAMIC) > + object->lockable = ((WINED3DPOOL_DEFAULT == Pool) || > (WINED3DPOOL_SYSTEMMEM > == Pool)) ? TRUE : > FALSE; The pool check here is somewhat redundant because a DYNAMIC texture of a non-default / non-systemmem pool will not reach that code due to the check added in patches 3 and 4. However, since one is in wined3d and the other check in d3d8/9 it somewhat makes sense to have it; I think we should discuss if we want the pool checks in wined3d or ddraw/d3d8/d3d9/d3d10. I'll take a look at the docs tomorrow.
> -----Original Message----- > From: [EMAIL PROTECTED] [mailto:wine-patches- > [EMAIL PROTECTED] On Behalf Of Tobias Jakobi > Sent: Monday, July 14, 2008 7:32 AM > To: [EMAIL PROTECTED] > Subject: [5/8] [wined3d] correctly set lockable boolean in > IWineD3DDeviceImpl_CreateVolume > > Hi there, > > this patchset fixes conformance of volumes/volumetextures creation > (plus > locking) in d3d8 and d3d9. Currently creating volumes/volumetextures > always succeeds regardless of the usage and pool type specified. > > A testcase for both d3d8 and d3d9 is included in the last two patches. > The test was verified on Vista and XP systems. > > Further fixes to volume/volumetexture locking are planned (the > behaviour is still not quite correct) and some of the fixes in this > patchset could be moved over to wined3d. That's also something that can > be done when the hardest work is over. > > Cheers, > Tobias Jakobi > > (PART 5/8) > >
