On Tue, Apr 7, 2009 at 9:30 AM, Ben Klein <shackl...@gmail.com> wrote:
> 2009/4/8 Vincent Povirk <madewokherd+8...@gmail.com>:
>> On Tue, Apr 7, 2009 at 5:43 AM, Dmitry Timoshkov <dmi...@codeweavers.com>
>> wrote:
>>> A real user who is trying to get real work done won't run the python
>>> test suite.
>>
>> True.
>>
>> On Tue, Apr 7, 2009 at 4:45 AM, Henri Verbeet <hverb...@gmail.com> wrote:
>>> Out of curiosity, why do the python tests even care if /bin/sh exists?
>>
>> The python tests run on multiple platforms, some of which have a
>> working /bin/sh. If it exists, certain ones (there are only two) will
>> start an sh process and read its output.
>>
>
> Surely this is still a bug in the Python test suite though. They
> should know that "/bin/sh" is not technically a valid path on
> Windows/DOS systems, and it only works due to system magic translating
> /'s to \'s.
"Working" in this case means that either:
* os.exists('/bin/sh') returns False (the case on Windows)
or
* Python can create a /bin/sh process and open a pipe to it (the case on Linux)
This doesn't depend on odd path translation in Windows/DOS.
The tests break on Wine because neither of those are true.
Vincent Povirk
