On Sun, Apr 12, 2009 at 5:24 PM, Ben Klein <[email protected]> wrote: > 2009/4/13 Vincent Povirk <[email protected]>: >> But the description doesn't say "invalid conditions". It says "serious >> errors in Wine". That's something that should never happen in tests, >> as it would imply that the state of the libraries we're testing (and >> thus the test) is invalid. > > How about "serious errors in Wine, or in the test cases, sometimes > deliberate errors in the tests"? As Vitaliy points out, some tests > deliberately do invalid things to make sure they fail. We can't ONLY > test on things that succeed!
I'm not against changing the description. If it's OK to have err messages for cases that we know fail (but don't crash or prevent the library from continuing to function), then the Developer's Guide is wrong and should be changed. I also don't care how long it takes to make the change, as long as there's a consensus that it's the guide that's wrong and not the reality of what's in Wine.
